mail: cross-probe From display name still reads 'gitborg monitoring' #388

Nytt ärende

Öppen

öppnade 2026-08-05 21:02:28 +00:00 av supernaut · 0 kommentarer

supernaut kommenterad

2026-08-05 21:02:28 +00:00

Ägare

The sending-domain move (#381) moved every mail address to email.bitborg.se, but the
cross-probe's display name was not part of that change and still reads gitborg:

{# roles/monitoring-agent/templates/bitborg-monitoring-probe.sh.j2:37 #}
echo "From: gitborg monitoring <${MAIL_FROM}>"

This is the same class of fault already fixed for forgejo_mailer_from on 2026-08-05 — the address
was correct while the From name was user-visible and wrong-cased. It reaches a real mailbox: the
cross-probe is the independent dead-man's-switch that emails admin@bitborg.se when the monitoring
VM dies, so the one time this header is read is during an incident.

Per the casing rule used for forgejo_app_name and forgejo_mailer_from, it should be
Bitborg monitoring.

Also in scope, operator-visible rather than user-visible

Three systemd unit descriptions on the monitoring host still say gitborg monitoring:

roles/monitoring/templates/caddy.container.j2:3
roles/monitoring/templates/caddy.socket.j2:15
roles/monitoring/templates/caddy-data.volume.j2:3

These show up in systemctl output. Cheap to fix in the same change, but note that editing a unit
description restarts the unit, so it is not free — Caddy on the monitoring host fronts Grafana
and ntfy.

Deliberately not in scope

Network={{ bitborg_network }} comments referring to "the gitborg network" describe an object whose
real name has not moved yet (the podman network rename is part of the data-carrying-objects tranche,
where editing a declaration creates a second empty object). Leave those until that tranche.

Acceptance

The cross-probe email header reads Bitborg monitoring.
A real send through the probe's own send_mail path shows the new display name in the received
message — verified on the received mail, not on the template.
Both hosts converge at changed=0.

The sending-domain move (#381) moved every mail **address** to `email.bitborg.se`, but the cross-probe's **display name** was not part of that change and still reads `gitborg`: ```jinja {# roles/monitoring-agent/templates/bitborg-monitoring-probe.sh.j2:37 #} echo "From: gitborg monitoring <${MAIL_FROM}>" ``` This is the same class of fault already fixed for `forgejo_mailer_from` on 2026-08-05 — the address was correct while the From *name* was user-visible and wrong-cased. It reaches a real mailbox: the cross-probe is the independent dead-man's-switch that emails `admin@bitborg.se` when the monitoring VM dies, so the one time this header is read is during an incident. Per the casing rule used for `forgejo_app_name` and `forgejo_mailer_from`, it should be `Bitborg monitoring`. ## Also in scope, operator-visible rather than user-visible Three systemd unit descriptions on the monitoring host still say `gitborg monitoring`: - `roles/monitoring/templates/caddy.container.j2:3` - `roles/monitoring/templates/caddy.socket.j2:15` - `roles/monitoring/templates/caddy-data.volume.j2:3` These show up in `systemctl` output. Cheap to fix in the same change, but note that editing a unit description **restarts the unit**, so it is not free — Caddy on the monitoring host fronts Grafana and ntfy. ## Deliberately not in scope `Network={{ bitborg_network }}` comments referring to "the gitborg network" describe an object whose real name has not moved yet (the podman network rename is part of the data-carrying-objects tranche, where editing a declaration creates a second **empty** object). Leave those until that tranche. ## Acceptance - The cross-probe email header reads `Bitborg monitoring`. - A real send through the probe's own `send_mail` path shows the new display name in the received message — verified on the received mail, not on the template. - Both hosts converge at `changed=0`.

supernaut lade till etiketterna

2026-08-05 21:02:33 +00:00

supernaut refererade till detta ärende från en incheckning

2026-08-05 21:07:40 +00:00

docs(runbook): record §5 mail as complete, with the verification

supernaut refererade till detta ärende

2026-08-05 21:07:59 +00:00

docs(runbook): record §5 mail as complete, with the verification #391