ci: build the container image on every pull request #48

Nytt ärende

Stängd

öppnade 2026-09-29 15:21:50 +00:00 av supernaut · 0 kommentarer

supernaut kommenterad

2026-09-29 15:21:50 +00:00

Ägare

CI never builds the container image. ci.yml runs lint, tests and pnpm build, but not the Containerfile. A broken image build only shows up when a v* tag is pushed and release.yml runs.

That happened with v0.1.1. The build stage did not copy pnpm-workspace.yaml, so pnpm install failed with ERR_PNPM_IGNORED_BUILDS on lefthook's postinstall. Every PR was green. The tag was left with no image, and the fix (#47) had to ship as v0.1.2.

Task

Add a step to ci.yml that builds the image from the Containerfile on every pull request, without pushing it. Use the same build command release.yml uses, so the two cannot drift.

Done when

A PR that breaks the Containerfile fails CI.
Checked with a negative control: revert the #47 fix on a throwaway branch and confirm CI goes red.

CI never builds the container image. `ci.yml` runs lint, tests and `pnpm build`, but not the `Containerfile`. A broken image build only shows up when a `v*` tag is pushed and `release.yml` runs. That happened with `v0.1.1`. The build stage did not copy `pnpm-workspace.yaml`, so `pnpm install` failed with `ERR_PNPM_IGNORED_BUILDS` on lefthook's postinstall. Every PR was green. The tag was left with no image, and the fix (#47) had to ship as `v0.1.2`. ## Task Add a step to `ci.yml` that builds the image from the `Containerfile` on every pull request, without pushing it. Use the same build command `release.yml` uses, so the two cannot drift. ## Done when - A PR that breaks the `Containerfile` fails CI. - Checked with a negative control: revert the #47 fix on a throwaway branch and confirm CI goes red.

supernaut lade till etiketterna

type

chore

area/ci

ready-for-implementation

2026-09-29 15:22:10 +00:00

supernaut lade till detta till projektet Bitborg Reconcile Trigger

2026-09-29 15:22:11 +00:00

supernaut refererade till detta ärende från en incheckning

2026-10-01 18:21:11 +00:00

ci: build the container image on every pull request

supernaut hänvisade till detta ärende från en ändringsförfrågan som kommer att stänga det