welcome page: the heading duplicates the step-4 label verbatim #120

Nytt ärende

Stängd

öppnade 2026-07-31 18:46:01 +00:00 av supernaut · 0 kommentarer

supernaut kommenterad

2026-07-31 18:46:01 +00:00

Ägare

/welcome renders the phrase "Start using Bitborg" twice, once as step 4 of the journey list and again immediately below as the page heading.

welcome.title (src/i18n/ui.ts) duplicates signup.step.start verbatim in both languages:

en: both are "Start using Bitborg"
sv: both are "Börja använda Bitborg"

Rendered, the page reads:

1. Your details            Done
2. Confirm your email      Done
3. Choose how you sign in  Done
4. Start using Bitborg     Current step
   Start using Bitborg          ← <h1>

Two costs. Visually it looks like a mistake. And the two strings must now be kept in sync by hand for no reason: change the step label and the heading silently disagrees with it, which is the same class of duplication the step model exists to prevent.

Options

Derive the heading from the step label — t("signup.step.start") for the <h1> and delete welcome.title. Guarantees they agree. But a page heading and a step label want different registers; "Start using Bitborg" is fine for both here, which may be luck rather than design.
Give the page its own heading that does not restate the step, e.g. en "You are ready" / sv "Du är klar". The step list already says which step this is, so the heading can carry something else.

Option 2 reads better and keeps <title> distinct from the step vocabulary. Either way one of the two strings should stop existing in its current form.

Done when

/welcome does not print the same sentence twice.

`/welcome` renders the phrase "Start using Bitborg" twice, once as step 4 of the journey list and again immediately below as the page heading. `welcome.title` (`src/i18n/ui.ts`) duplicates `signup.step.start` verbatim in both languages: - en: both are "Start using Bitborg" - sv: both are "Börja använda Bitborg" Rendered, the page reads: ``` 1. Your details Done 2. Confirm your email Done 3. Choose how you sign in Done 4. Start using Bitborg Current step Start using Bitborg ← <h1> ``` Two costs. Visually it looks like a mistake. And the two strings must now be kept in sync by hand for no reason: change the step label and the heading silently disagrees with it, which is the same class of duplication the step model exists to prevent. ## Options 1. **Derive the heading from the step label** — `t("signup.step.start")` for the `<h1>` and delete `welcome.title`. Guarantees they agree. But a page heading and a step label want different registers; "Start using Bitborg" is fine for both here, which may be luck rather than design. 2. **Give the page its own heading** that does not restate the step, e.g. en "You are ready" / sv "Du är klar". The step list already says which step this is, so the heading can carry something else. Option 2 reads better and keeps `<title>` distinct from the step vocabulary. Either way one of the two strings should stop existing in its current form. ## Done when `/welcome` does not print the same sentence twice.

supernaut lade till etiketterna

area/web

ready-for-implementation

type

bug

2026-07-31 18:46:43 +00:00

supernaut lade till detta till projektet Bitborg Web

2026-07-31 18:46:45 +00:00

supernaut refererade till detta ärende från en incheckning

2026-07-31 18:55:42 +00:00

fix(signup): journey follow-ups — heading, announcement, sitemap, sign-in note

supernaut hänvisade till detta ärende från en ändringsförfrågan som kommer att stänga det