bitborg/bitborg-web

Bevaka

Avgrena 0

welcome page: missing the "you may already be signed in" note the design specified #124

Nytt ärende

Stängd

öppnade 2026-07-31 18:46:26 +00:00 av supernaut · 1 kommentar

supernaut kommenterad

2026-07-31 18:46:26 +00:00

Ägare

The design specified that /welcome would tell the user they may already be signed in; the implemented page does not.

Design §5 (bitborg-internal/plans/2026-07-31-signup-journey-design.md):

One prominent "Sign in to Bitborg" action that starts the Forgejo login, plus a line noting they may already be signed in.

welcome.body carries only the first half: "If you have chosen how you sign in, you are ready. Sign in to Bitborg to finish setting up."

Why the missing line mattered

The page is reached straight after setting a passkey on Gitborg Auth, at which point the user is authenticated there. Clicking "Sign in to Bitborg" may therefore complete without prompting for anything — which, to someone who has just been asked for a credential twice, can read as "it didn't work, nothing happened".

One sentence removes that doubt: they are told in advance that sign-in may be immediate, so a fast, silent success reads as success rather than as a no-op.

Fix

Add a sentence to welcome.body in both languages, or a separate hint key beneath the action. Suggested:

en: "You may be signed in already, in which case this takes you straight there."
sv: "Du kan redan vara inloggad, och då kommer du direkt vidare."

Swedish "inloggad" matches Forgejo's logga in vocabulary.

Done when

/welcome sets the expectation that sign-in may complete without a prompt.

The design specified that `/welcome` would tell the user they may already be signed in; the implemented page does not. Design §5 (`bitborg-internal/plans/2026-07-31-signup-journey-design.md`): > One prominent "Sign in to Bitborg" action that starts the Forgejo login, plus a line noting they may already be signed in. `welcome.body` carries only the first half: "If you have chosen how you sign in, you are ready. Sign in to Bitborg to finish setting up." ## Why the missing line mattered The page is reached straight after setting a passkey on Gitborg Auth, at which point the user **is** authenticated there. Clicking "Sign in to Bitborg" may therefore complete without prompting for anything — which, to someone who has just been asked for a credential twice, can read as "it didn't work, nothing happened". One sentence removes that doubt: they are told in advance that sign-in may be immediate, so a fast, silent success reads as success rather than as a no-op. ## Fix Add a sentence to `welcome.body` in both languages, or a separate hint key beneath the action. Suggested: - en: "You may be signed in already, in which case this takes you straight there." - sv: "Du kan redan vara inloggad, och då kommer du direkt vidare." Swedish "inloggad" matches Forgejo's `logga in` vocabulary. ## Done when `/welcome` sets the expectation that sign-in may complete without a prompt.

supernaut lade till etiketterna

area/web

ready-for-implementation

type

task

2026-07-31 18:46:44 +00:00

supernaut lade till detta till projektet Bitborg Web

2026-07-31 18:46:48 +00:00

supernaut refererade till detta ärende från en incheckning

2026-07-31 18:55:42 +00:00

fix(signup): journey follow-ups — heading, announcement, sitemap, sign-in note

supernaut refererade till detta ärende

2026-07-31 18:55:43 +00:00

fix(signup): journey follow-ups — heading, announcement, sitemap, sign-in note, journey() seam #125

supernaut refererade till detta ärende från en incheckning

2026-07-31 19:14:57 +00:00

fix(signup): journey follow-ups — heading, announcement, sitemap, sign-in note, journey() seam (#125)

supernaut kommenterad

2026-08-01 14:17:07 +00:00

Upphovsperson

Ägare

Already done — shipped by 8439fa4 (PR #125); its close keywords never fired.

Verified in `src/i18n/ui.ts`: `welcome.body` carries the note in both locales — en "You may be
signed in already, in which case it takes you straight there.", sv "Du kan redan vara inloggad, och
då kommer du direkt vidare."

Closing as already implemented.

Already done — shipped by 8439fa4 (PR #125); its close keywords never fired. Verified in \`src/i18n/ui.ts\`: \`welcome.body\` carries the note in both locales — en "You may be signed in already, in which case it takes you straight there.", sv "Du kan redan vara inloggad, och då kommer du direkt vidare." Closing as already implemented.

supernaut stängde ärendet

2026-08-01 14:17:07 +00:00

supernaut refererade till detta ärende

2026-08-01 14:18:04 +00:00

fix(content): lead with the trial, brand the 404 page #136

supernaut refererade till detta ärende från en incheckning

2026-08-03 09:41:50 +00:00

fix(signup): journey follow-ups — heading, announcement, sitemap, sign-in note, journey() seam (#125)

Logga in för att delta i denna konversation.