fix(signup): render the intro copy, which was written but never displayed #214
Inga granskare
Etiketter
Inga etiketter
area/backups
area/ci
area/control-panel
area/identity
area/infra
area/observability
area/payments
area/security
area/storage
area/web
blocked
needs-info
needs-triage
ready-for-implementation
type
bug
type
chore
type
docs
type
epic
type
feature
type
task
wontfix
Ingen milstolpe
Inget projekt
Inga tilldelade
1 deltagare
Notiser
Förfallodatum
Inget förfallodatum satt.
Beroenden
Inga beroenden satta
Referens
bitborg/bitborg-web!214
Läser in…
Hänvisa till i nytt ärende
Ingen beskrivning angiven.
Ta bort grenen "feat/launch-polish"
Borttagning av en gren är permanent. Även om den borttagna grenen kan fortsätta existera en kort tid innan den faktiskt tas bort, kan det INTE ångras i de flesta fall. Vill du fortsätta?
src/i18n/ui.tshas carriedsignup.introandsignup.introTrialsince the copy for #133landed. No component ever referenced either key. A grep finds them only in the translation
table itself.
So
/signupshows no intro paragraph at all. The copy exists, in both languages, and rendersnowhere. This adds the three lines that render it.
The paragraph follows the same trial kill switch as the checkbox below it. While the trial is
open a visitor reads what they can get today. The pre-trial wording returns on its own once
paid subscriptions exist. Nothing else is needed. Both strings and the
showTrialgate arealready in place.
The trial checkbox stays unchecked. Ticking it accepts a separate legal document, so it is a
consent control, and a pre-ticked consent box is not consent. It would also not match the Terms
box beneath it.
Note on the commit message
The commit on this branch predates several merged PRs. It describes
/pricingchanges that havesince landed separately. The diff here is only the
/signupparagraph. This description isaccurate; the commit body is not.
Verified
pnpm test: 305 passedpnpm check: 0 errors, 0 warningsCloses #133
The announcement drives traffic to /pricing, which advertised 150 kr a month and never mentioned the trial that is the offer actually on the table. /signup had the mirror problem: it described the account you get as a participant account and put hosting your own repositories behind "the paid account", which cannot be bought yet. - /pricing now opens with the trial, links the trial terms, and frames the prices as what an account will cost, with a short note beside the price list. - pricing.description leads with the trial, since that is the line a search result shows. - The sign-up intro follows the trial kill switch: while the trial is open it leads with what a visitor gets today; the previous wording stays for the world where paid subscriptions exist. - The date framing is reused verbatim from the trial terms, the news post and the control panel ("at least until 31 August 2026" / "minst till 31 augusti 2026"). The trial checkbox stays unchecked. Ticking it accepts a separate legal document, so it is a consent control and a pre-ticked consent box is not consent; it would also not match the Terms box beneath it. The conversion loss is answered in the copy instead.592ffcfbc4b9af537189b9af53718924f0a8cc3d