bitborg/bitborg-web
Bevaka
2
0
Avgrena
Du har redan avgrenat bitborg-web
 0
Kod Ärenden 13 Ändringsförfrågningar 3 Projekt 1 Utgåvor Paket 1 Aktiviteter Actions

fix(a11y): two navigation landmarks are both called "Bitborg" #157

Nytt ärende
Stängd
öppnade 2026-08-02 12:30:09 +00:00 av supernaut · 0 kommentarer
supernaut kommenterad 2026-08-02 12:30:09 +00:00
Ägare
Kopiera länk

Every page exposes these navigation landmarks:

Sekundär navigering · Byt språk · Navigering · Bitborg · Bitborg · Legal

Two of them share a name:

  • src/components/main-navigation.astro:95 uses nav.app.label (src/i18n/ui.ts:71 / :343) =
    "Bitborg" — the "Open Bitborg" external link.
  • src/components/footer.astro:106 uses nav.service.label (src/i18n/ui.ts:83 / :355) =
    "Bitborg" — the footer service column.

A screen reader's landmark list offers "Bitborg navigation" twice with no way to tell them apart
(WCAG 1.3.1). src/pages/404.astro:32-34 already documents this exact rule and follows it there.

Two smaller problems in the same strings:

  • nav.main.label ("Main Navigation" / "Navigering") and nav.secondary.label ("Secondary
    Navigation" / "Sekundär navigering") repeat the role — announced as "Main Navigation navigation".
  • nav.legal.label is the string "Legal" in both dictionaries (src/i18n/ui.ts:75 and :347)
    and renders as visible Swedish copy in the footer (src/components/footer.astro:122).

Fix

src/i18n/ui.ts only, both dictionaries. docs/content-style.md § "Product & feature terms" says
the git application is just "Bitborg", with the hostname added only where the website and the
application must be told apart — which is this case.

Key Now (en / sv) Proposed (en / sv)
nav.app.label Bitborg / Bitborg Bitborg at git.gitborg.se / Bitborg på git.gitborg.se
nav.main.label Main Navigation / Navigering Pages / Sidor
nav.secondary.label Secondary Navigation / Sekundär navigering Account / Konto
nav.legal.label Legal / Legal Legal / Villkor

nav.service.label stays "Bitborg" — it is a visible footer heading, and the pair is unique once
nav.app.label changes.

Done when

  • No two navigation landmarks on any page share an accessible name.
  • No landmark name contains "navigation" or "navigering".
  • pnpm lang-check passes and the copy has been checked against docs/content-style.md.

Part of gitborg/gitborg-docs#67.

Every page exposes these navigation landmarks: Sekundär navigering · Byt språk · Navigering · Bitborg · Bitborg · Legal Two of them share a name: - `src/components/main-navigation.astro:95` uses `nav.app.label` (`src/i18n/ui.ts:71` / `:343`) = "Bitborg" — the "Open Bitborg" external link. - `src/components/footer.astro:106` uses `nav.service.label` (`src/i18n/ui.ts:83` / `:355`) = "Bitborg" — the footer service column. A screen reader's landmark list offers "Bitborg navigation" twice with no way to tell them apart (WCAG 1.3.1). `src/pages/404.astro:32-34` already documents this exact rule and follows it there. Two smaller problems in the same strings: - `nav.main.label` ("Main Navigation" / "Navigering") and `nav.secondary.label` ("Secondary Navigation" / "Sekundär navigering") repeat the role — announced as "Main Navigation navigation". - `nav.legal.label` is the string "Legal" in **both** dictionaries (`src/i18n/ui.ts:75` and `:347`) and renders as visible Swedish copy in the footer (`src/components/footer.astro:122`). ## Fix `src/i18n/ui.ts` only, both dictionaries. `docs/content-style.md` § "Product & feature terms" says the git application is just "Bitborg", with the hostname added only where the website and the application must be told apart — which is this case. | Key | Now (en / sv) | Proposed (en / sv) | | --- | --- | --- | | `nav.app.label` | Bitborg / Bitborg | Bitborg at git.gitborg.se / Bitborg på git.gitborg.se | | `nav.main.label` | Main Navigation / Navigering | Pages / Sidor | | `nav.secondary.label` | Secondary Navigation / Sekundär navigering | Account / Konto | | `nav.legal.label` | Legal / Legal | Legal / Villkor | `nav.service.label` stays "Bitborg" — it is a visible footer heading, and the pair is unique once `nav.app.label` changes. ## Done when - No two navigation landmarks on any page share an accessible name. - No landmark name contains "navigation" or "navigering". - `pnpm lang-check` passes and the copy has been checked against `docs/content-style.md`. Part of gitborg/gitborg-docs#67.
supernaut lade till detta till projektet Bitborg Web 2026-08-02 12:34:24 +00:00
supernaut ändrade titeln från fix(a11y): two navigation landmarks are both called "Gitborg" till fix(a11y): two navigation landmarks are both called "Bitborg" 2026-08-03 09:58:55 +00:00
Logga in för att delta i denna konversation.
Ingen gren/etikett specificerad
Grenar Taggar
main
feat/279-renewal-date
feat/149-paid-signup
test/csrf-origin-check
Inga resultat hittades.
Etiketter
Rensa etiketter
  
area/backups
Backup & restore

  
area/ci
Actions / runners

  
area/control-panel
Logged-in self-service area

  
area/identity
Kanidm / OIDC / entitlements

  
area/infra
Infrastructure (OpenTofu/Ansible/host)

  
area/observability
Monitoring / logs / analytics

  
area/payments
Billing / payment providers

  
area/security
Security & compliance (incl. ISO 27001)

  
area/storage
Volumes / data / LFS

  
area/web
Public web portal (gitborg-web)

  
blocked
Evaluated and specified, but waiting on an external dependency

  
needs-info
Waiting on the reporter for more information

  
needs-triage
Not yet evaluated

  
ready-for-implementation
Fully specified, ready to be picked up

  
type
bug
 Something is broken

  
type
chore
 Maintenance / housekeeping

  
type
docs
 Documentation

  
type
epic
 High-level roadmap item

  
type
feature
 New capability

  
type
task
 Concrete unit of work

  
wontfix
Will not be actioned

Inga etiketter
area/backups
area/ci
area/control-panel
area/identity
area/infra
area/observability
area/payments
area/security
area/storage
area/web
blocked
needs-info
needs-triage
ready-for-implementation
type
bug
type
chore
type
docs
type
epic
type
feature
type
task
wontfix
Milstolpe
Rensa milstolpe
Inga objekt
Ingen milstolpe
Projekt
Rensa projekt
Inga objekt
Inget projekt
Bitborg Web
Tilldelade
Rensa tilldelade
Inga tilldelade
1 deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet "åååå-mm-dd".

Inget förfallodatum satt.

Beroenden

Inga beroenden satta

Referens
bitborg/bitborg-web#157
Ingen beskrivning angiven.