chore(nav): remove dead navigation css and redundant attributes #238

Sammanfogat

supernaut sammanfogade 1 incheckning från work/161 in i main

2026-09-21 06:50:26 +00:00

supernaut kommenterad

2026-09-20 22:20:25 +00:00

Ägare

Four cleanups found while reviewing the navigation. None of them changes behaviour a reader can see, except that inactive links now ship no aria-current attribute at all.

user-menu.astro: deleted the .sign-out-form CSS block. The selector never matched, because sign-out.astro renders .sign-out. The rules that do the work are the near-identical copy in sign-out.astro, left untouched.
main-navigation.astro: activeProps returned the string "false", so every inactive link shipped aria-current="false". It returns undefined now, so Astro omits the attribute. isActivePath and src/lib/nav.test.ts are unchanged.
language-switcher.astro: dropped the title attribute. It duplicated the aria-label text, added a second desktop tooltip and did nothing on touch.
variables.scss: the comment on --color-btn-secondary-* named a nav item that is an IconLink now.

Patch version bump: meaning-preserving cleanup.

Verified: pnpm lint, pnpm check and pnpm test all pass (361 tests, nav.test.ts unchanged).

Closes #161

Four cleanups found while reviewing the navigation. None of them changes behaviour a reader can see, except that inactive links now ship no `aria-current` attribute at all. - `user-menu.astro`: deleted the `.sign-out-form` CSS block. The selector never matched, because `sign-out.astro` renders `.sign-out`. The rules that do the work are the near-identical copy in `sign-out.astro`, left untouched. - `main-navigation.astro`: `activeProps` returned the string `"false"`, so every inactive link shipped `aria-current="false"`. It returns `undefined` now, so Astro omits the attribute. `isActivePath` and `src/lib/nav.test.ts` are unchanged. - `language-switcher.astro`: dropped the `title` attribute. It duplicated the `aria-label` text, added a second desktop tooltip and did nothing on touch. - `variables.scss`: the comment on `--color-btn-secondary-*` named a nav item that is an `IconLink` now. Patch version bump: meaning-preserving cleanup. Verified: `pnpm lint`, `pnpm check` and `pnpm test` all pass (361 tests, `nav.test.ts` unchanged). Closes #161

supernaut lade till 1 incheckning

2026-09-20 22:20:25 +00:00

chore(nav): remove dead css and fix aria-current/comment cleanup

ci / ci (pull_request) Successful in 1m22s

Detaljer

3a94c231d0

Delete unused .sign-out-form styles in user-menu.astro (selector never
matched; sign-out.astro renders .sign-out). Return undefined instead of
"false" from activeProps so inactive nav links omit aria-current rather
than shipping it as a literal string. Drop the redundant title on the
language switcher's aria-labelled IconLink. Fix a stale comment in
variables.scss: the nav "Skapa konto" item is an IconLink now, not a
secondary button.

supernaut sammanfogade incheckning 98cc5454c7 till main

2026-09-21 06:50:26 +00:00

supernaut tog bort grenen work/161

2026-09-21 06:50:26 +00:00

supernaut refererade denna ändringsförfrågan från en incheckning

2026-09-21 06:50:27 +00:00

chore(nav): remove dead navigation css and redundant attributes (#238)

supernaut refererade denna ändringsförfrågan från en incheckning

2026-10-02 17:56:59 +00:00

chore(nav): remove dead navigation css and redundant attributes (#238)

Logga in för att delta i denna konversation.

Inga granskare